Overwrite custom resources by new data instead of appending to old data #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jlineaweaver/cap-1652 #1473 +/- ##
=========================================================
- Coverage 49.22% 48.96% -0.27%
=========================================================
Files 225 224 -1
Lines 19854 19725 -129
=========================================================
- Hits 9774 9659 -115
+ Misses 9570 9563 -7
+ Partials 510 503 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mfpierre
approved these changes
Oct 18, 2024
levan-m
added a commit
that referenced
this pull request
Oct 22, 2024
* [Orch] Add CRD RC handler * Remove print statement * Refactor to separate file * Move last function * Use CRD specific status * Add cluster agent config to RC * Correctly set product * Fix product and add logging * Add fixes for crd nil pointers * Revert accidental commit * Update dependencies and add tag getter function * Go.mod change * Reset go.mod * Update remoteconfig/state * Fix updater package and work sum * Clean up logs and force restart of DCA on CR changes * Add a lock around get and update of DDA * Improve comments and change test to use orchexp for annotation * Change to not do annotations every single time * Fill in orchestrator explorer for tests * Go mod update * Modify retry logic so it doesn't it for the entire update * Fix go.mod * Check in config crd stuff * Remove hard coded product and update go.mod * Revert go.mod back and fix errors * Go.sum update * overwrite cr by incoming data instead of appending to the old data (#1473) * feedback * feedback * rename to OrchestratorK8sCRDRemoteConfig --------- Co-authored-by: Kangyi LI <kangyi.li@datadoghq.com> Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
levan-m
added a commit
that referenced
this pull request
Oct 22, 2024
* [Orch] Add CRD RC handler * Remove print statement * Refactor to separate file * Move last function * Use CRD specific status * Add cluster agent config to RC * Correctly set product * Fix product and add logging * Add fixes for crd nil pointers * Revert accidental commit * Update dependencies and add tag getter function * Go.mod change * Reset go.mod * Update remoteconfig/state * Fix updater package and work sum * Clean up logs and force restart of DCA on CR changes * Add a lock around get and update of DDA * Improve comments and change test to use orchexp for annotation * Change to not do annotations every single time * Fill in orchestrator explorer for tests * Go mod update * Modify retry logic so it doesn't it for the entire update * Fix go.mod * Check in config crd stuff * Remove hard coded product and update go.mod * Revert go.mod back and fix errors * Go.sum update * overwrite cr by incoming data instead of appending to the old data (#1473) * feedback * feedback * rename to OrchestratorK8sCRDRemoteConfig --------- Co-authored-by: Kangyi LI <kangyi.li@datadoghq.com> Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
levan-m
added a commit
that referenced
this pull request
Oct 22, 2024
* [Orch] Add CRD RC handler * Remove print statement * Refactor to separate file * Move last function * Use CRD specific status * Add cluster agent config to RC * Correctly set product * Fix product and add logging * Add fixes for crd nil pointers * Revert accidental commit * Update dependencies and add tag getter function * Go.mod change * Reset go.mod * Update remoteconfig/state * Fix updater package and work sum * Clean up logs and force restart of DCA on CR changes * Add a lock around get and update of DDA * Improve comments and change test to use orchexp for annotation * Change to not do annotations every single time * Fill in orchestrator explorer for tests * Go mod update * Modify retry logic so it doesn't it for the entire update * Fix go.mod * Check in config crd stuff * Remove hard coded product and update go.mod * Revert go.mod back and fix errors * Go.sum update * overwrite cr by incoming data instead of appending to the old data (#1473) * feedback * feedback * rename to OrchestratorK8sCRDRemoteConfig --------- Co-authored-by: Joshua Lineaweaver <JLineaweaver@gmail.com> Co-authored-by: Kangyi LI <kangyi.li@datadoghq.com> Co-authored-by: Fanny Jiang <fanny.jiang@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel